Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve locking on JavacCompiler #315

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Improve locking on JavacCompiler #315

merged 1 commit into from
Nov 22, 2023

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Oct 28, 2023

  • the code synchonizes on the CopyOnWriteArrayList which is a concurrent collection
  • the double check locking pattern is badly written and does not actually double checks

@gnodet
Improve locking on JavacCompiler
3dc1ca7 
- the code synchonizes on the CopyOnWriteArrayList which is a concurrent collection
- the double check locking pattern is badly written and does not actually double checks
@gnodet gnodet force-pushed the improve-locking-javac branch from 5204b48 to 3dc1ca7 Compare October 28, 2023 09:35
@olamy olamy merged commit b941e70 into codehaus-plexus:master Nov 22, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmannibucau rmannibucau rmannibucau approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnodet @rmannibucau @olamy